janjaali commented on code in PR #267:
URL:
https://github.com/apache/pekko-persistence-jdbc/pull/267#discussion_r1948076107
##########
core/src/main/scala/org/apache/pekko/persistence/jdbc/query/dao/DefaultReadJournalDao.scala:
##########
@@ -60,6 +60,12 @@ class DefaultReadJournalDao(
override def journalSequence(offset: Long, limit: Long): Source[Long,
NotUsed] =
Source.fromPublisher(db.stream(queries.journalSequenceQuery((offset,
limit)).result))
+ override def lastPersistenceIdSequenceNumber(
+ persistenceId: String
Review Comment:
Sure! Tried to align to existing code style in
<https://github.com/apache/pekko-persistence-jdbc/pull/267/commits/49b7262dbcfe47279d580537a7c65dcdfd460fc8>.
##########
core/src/main/scala/org/apache/pekko/persistence/jdbc/query/dao/ReadJournalQueries.scala:
##########
@@ -29,6 +29,9 @@ class ReadJournalQueries(val profile: JdbcProfile, val
readJournalConfig: ReadJo
val messagesQuery = Compiled(_messagesQuery _)
val eventsByTag = Compiled(_eventsByTag _)
val journalSequenceQuery = Compiled(_journalSequenceQuery _)
+ val lastPersistenceIdSequenceNumberQuery = Compiled {
+ _lastPersistenceIdSequenceNumberQuery _
Review Comment:
Sure! Tried to align to existing code style in
<https://github.com/apache/pekko-persistence-jdbc/pull/267/commits/49b7262dbcfe47279d580537a7c65dcdfd460fc8>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
