pjfanning commented on code in PR #267:
URL:
https://github.com/apache/pekko-persistence-jdbc/pull/267#discussion_r1948070108
##########
core/src/main/scala/org/apache/pekko/persistence/jdbc/query/javadsl/JdbcReadJournal.scala:
##########
@@ -132,4 +139,14 @@ class JdbcReadJournal(journal: ScalaJdbcReadJournal)
*/
override def eventsByTag(tag: String, offset: Offset): Source[EventEnvelope,
NotUsed] =
journal.eventsByTag(tag, offset).asJava
+
+ override def currentLastKnownSequenceNumberByPersistenceId(
+ persistenceId: String
+ ): CompletionStage[Optional[Long]] = {
Review Comment:
why is this using Java Optional and not Scala Option?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
