ptrdom commented on PR #170: URL: https://github.com/apache/pekko-persistence-r2dbc/pull/170#issuecomment-2466213653
> I would suggest that dialect does not appear in the new reference.conf and that we change the projection-core reference.conf to mention that dialect=mysql is valid but that you also need to add a dependency to projection-mysql jarif you set that value. > > The projection-mysql reference.conf should scope its configs with `pekko.persistence.r2dbc.mysql` instead of `pekko.persistence.r2dbc`. I understand the `reference.conf` changes you are proposing, but I do not understand how they are supposed to work within the implementation. Could you provide examples of how your proposed config should work with MySQL implementation being in a separate sbt module? Mainly I do not see how to meaningfully implement `dialect = mysql`, what should `core` do when it encounters it, why are we making core aware of MySQL? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
