pjfanning commented on code in PR #170:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/170#discussion_r1835349073
##########
core-mysql/src/main/scala/org/apache/pekko/persistence/r2dbc/mysql/journal/MySQLJournalDao.scala:
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * license agreements; and to You under the Apache License, version 2.0:
Review Comment:
* if you copy/paste code from another source file (whole class or just some
lines), you need to also copy the source header from the file you copied from
(even if you modify that copied code)
* if you add new code to a source file and that source file does not have a
source header that matches the license under which your new code is licensed,
then you should add the right source header (but don't remove any existing
source headers)
* you can avoid duplication
* you might have 2 Apache source headers that might have different
copyright lines - you can merge those headers into one header but with 2
copyright lines
* in Pekko, we use 2 forms of the Apache header - one that mentions Akka
but we also use the standard Apache header if none of the code in the file is
derived from Akka - we don't need both Apache headers in the same file - we
just use the Pekko specific one (mentioning Akka)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
