ptrdom commented on code in PR #170:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/170#discussion_r1835311628
##########
core-mysql/src/main/resources/reference.conf:
##########
@@ -0,0 +1,31 @@
+# SPDX-License-Identifier: Apache-2.0
+
+// #connection-settings
+pekko.persistence.r2dbc {
+
+ # setting dialect to empty toggles use of the following class config
Review Comment:
No, valid `dialect` values are declared here -
https://github.com/apache/pekko-persistence-r2dbc/blob/main/core/src/main/resources/reference.conf#L105.
Setting `dialect` to empty enables loading of DAO classes specified by
`journalDaoClass`, `queryDaoClass`, `snapshotDaoClass`, `durableStateDaoClass`
configs instead of using default Postgres/Yugabyte implementation. This is the
only way I figured MySQL implementation could be plugged in as a separate sbt
module. This also provides flexibility in a way that library's users could plug
their own DAO implementations and provide support for new databases without
making changes to the library.
If you have any suggestions for improvements to implementation or docs,
please let me know,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
