pjfanning commented on code in PR #171: URL: https://github.com/apache/pekko-persistence-r2dbc/pull/171#discussion_r1830935332
########## core/src/main/scala/org/apache/pekko/persistence/r2dbc/ConnectionFactoryProvider.scala: ########## @@ -18,13 +18,17 @@ import java.util.concurrent.ConcurrentHashMap import scala.concurrent.Future import scala.concurrent.duration.Duration +import scala.util.Failure Review Comment: minor nit but could you use `scala.util.{ Failure, Success }`? -- likewise with other new imports -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org