ptrdom commented on code in PR #171:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/171#discussion_r1830881971
##########
core/src/main/scala/org/apache/pekko/persistence/r2dbc/ConnectionFactoryProvider.scala:
##########
@@ -40,6 +44,14 @@ object ConnectionFactoryProvider extends
ExtensionId[ConnectionFactoryProvider]
// Java API
def get(system: ActorSystem[_]): ConnectionFactoryProvider = apply(system)
+
+ trait ConnectionFactoryOptionsCustomizer {
+ def apply(options: ConnectionFactoryOptions, config: Config):
ConnectionFactoryOptions
Review Comment:
Would it be better if argument and return type were
`ConnectionFactoryOptions.Builder`?
```scala
def apply(builder: ConnectionFactoryOptions.Builder, config: Config):
ConnectionFactoryOptions.Builder
```
Because for any mutation the `options` here would need to be converted back
to builder again anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
