pjfanning commented on code in PR #171:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/171#discussion_r1828345753
##########
core/src/main/resources/reference.conf:
##########
@@ -169,6 +169,12 @@ pekko.persistence.r2dbc {
# Enabling this has some performance overhead.
# A fast query for Postgres is "SELECT 1"
validation-query = ""
+
+ # FQCN of an OptionsCustomizer. If non-empty, it must be the fully
qualified class
+ # name of a class implementing the trait
ConnectionFactoryProvider.OptionsCustomizer.
+ # The class must have a constructor with a single parameter of type
ActorSystem[_].
+ # If this setting is empty, the default no-op customizer will be used.
+ options-customizer = ""
Review Comment:
this name is too short, afiac - when I see Option, I think scala.Option. Can
we rename this as `connectionfactoryoptions-customizer`? Likewise for the
actual classes (ie include ConnectionFactory in the class names).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
