Kami commented on code in PR #1946:
URL: https://github.com/apache/libcloud/pull/1946#discussion_r1324941487
##########
libcloud/compute/drivers/linode.py:
##########
@@ -997,6 +1038,12 @@ def create_node(
:keyword ex_private_ip: whether or not to request a private IP
:type ex_private_ip: ``bool``
+ :keyword ex_userdata: add cloud-config compatible userdata to be
Review Comment:
I think it would actually be better to let user pass in a raw string and
then we can take care of base64 encoding the string inside the method ourselves.
This way the method abstracts away this implementation detail from the end
user (we already do a similar thing in a bunch of places).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
