Kami commented on code in PR #1946:
URL: https://github.com/apache/libcloud/pull/1946#discussion_r1324937049
##########
libcloud/compute/drivers/linode.py:
##########
@@ -945,15 +973,28 @@ def reboot_node(self, node):
def create_node(
self,
location,
- size,
- image=None,
- name=None,
+ # Previously, the following 3 parameters did not match the rest of the
libcloud
+ # codebase drivers. They should be in the same order as other compute
drivers.
+ # Previously, it looked like this:
+ # size,
+ # image=None,
+ # name=None,
+ #
+ # Comments welcome on how backwards compatibility (if any) should work
here.
Review Comment:
I think it's fine to leave it as-in and document this backward incompatible
/ breaking change in the upgrade notes file
(https://github.com/apache/libcloud/blob/trunk/docs/upgrade_notes.rst), ideally
with some concrete before / after code examples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
