Kami commented on PR #1946: URL: https://github.com/apache/libcloud/pull/1946#issuecomment-1718152962
@mraygalaxy2 Thanks for adding the tests and addressing some very old API inconsistency in the ``create_node()`` method. I think it would be good to document that breaking API change in the upgrade notes file (https://github.com/apache/libcloud/commit/d8add44eec876cae1103b99d545a747a0e33a4bc#r127271125). Besides that, LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
