LamiumAmplexicaule commented on PR #7451: URL: https://github.com/apache/kyuubi/pull/7451#issuecomment-5010631101
@wangzhigang1999 Thank you for your review. > the PR description should refer to kyuubi.server.redaction.regex I updated the PR description. > the stale serverOnly comments can be updated. I fixed it in https://github.com/apache/kyuubi/pull/7451/changes/cbf70e153acf3dc5c3e0e03f88569bd10158ac87. @pan3793 Thank you for your review. > Issue 1: redactCommandLineArgs drops the --conf guard — widens redaction scope I added an explanation to the PR description. > Issue 2: Stale serverOnly comments in KyuubiServerInfoProviderSuite I fixed it in https://github.com/apache/kyuubi/pull/7451/changes/cbf70e153acf3dc5c3e0e03f88569bd10158ac87. > There is no longer a serverOnly flag; the test now exercises the audience + immutable behavior. As mentioned below, `SERVER_INFO_PROVIDER` needs to remain immutable, so I haven’t made it mutable. - https://github.com/apache/kyuubi/pull/7451#issuecomment-4767528203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
