wangzhigang1999 commented on PR #7451: URL: https://github.com/apache/kyuubi/pull/7451#issuecomment-4978047070
LGTM from my side. Thanks for addressing the compatibility concerns. Two minor cleanup items remain: the PR description should refer to `kyuubi.server.redaction.regex`, and the stale `serverOnly` comments can be updated. Neither is blocking. Since this PR changes how configuration is validated and propagated to every engine, I would still like another reviewer to take a close look before merging. I’ll also run a few more tests on my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
