pan3793 commented on code in PR #7451: URL: https://github.com/apache/kyuubi/pull/7451#discussion_r3600093405
########## AGENTS.md: ########## @@ -130,7 +130,11 @@ Runtime dependency changes may also require `LICENSE-binary` and `NOTICE` update Configs are `ConfigEntry` instances in `KyuubiConf` or per-engine config classes. -- Server-only entries call `.serverOnly` on the builder; `KyuubiConf` tracks them in `serverOnlyConfEntries` so they are stripped before engine-side propagation. +- Each config entry has two independent access-control properties: + - **`audience`** — which consumers should receive the config. Set via `.audience(SERVER)`, `.audience(SPARK)`, etc. on the builder. Entries without explicit audience use prefix-based inference (`inferAudience`). Review Comment: ```patch - ... use prefix-based inference (`inferAudience`) + ... use prefix-based inference (`ConfigAudience.inferAudience`) ``` ########## AGENTS.md: ########## @@ -130,7 +130,11 @@ Runtime dependency changes may also require `LICENSE-binary` and `NOTICE` update Configs are `ConfigEntry` instances in `KyuubiConf` or per-engine config classes. -- Server-only entries call `.serverOnly` on the builder; `KyuubiConf` tracks them in `serverOnlyConfEntries` so they are stripped before engine-side propagation. +- Each config entry has two independent access-control properties: + - **`audience`** — which consumers should receive the config. Set via `.audience(SERVER)`, `.audience(SPARK)`, etc. on the builder. Entries without explicit audience use prefix-based inference (`inferAudience`). + - **`immutable`** — whether users can override the config at session time. Set via `.immutable` on the builder. Admin-controlled sources (user defaults, session conf advisors) bypass immutable checks. +- Server-only entries use `.audience(SERVER)` and `.immutable` on the builder. Review Comment: seems we can eliminate the server-only concept now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
