wangzhigang1999 commented on PR #7417: URL: https://github.com/apache/kyuubi/pull/7417#issuecomment-4302231102
Hi @pan3793, when you have time, could I ask for a review on this one? 🙏 Third PR of the Data Agent Engine series ([umbrella #7379](https://github.com/apache/kyuubi/issues/7379), labeled 2b/4) — adds the `ReactAgent` runtime, middleware stack (logging / approval / compaction / tool-output offload), and `OpenAiProvider`. Sits on top of 2a (#7400) and is consumed by the final REST-layer PR. It's on the larger side (~5.3k lines, almost all under `externals/kyuubi-data-agent-engine/`), so a high-level pass on the agent/middleware shape and session lifecycle is more than enough — happy to iterate on line-level feedback after. `ReactAgentLiveTest` exercises the full loop end-to-end if easier to poke at locally (needs `DATA_AGENT_LLM_API_KEY` / `DATA_AGENT_LLM_API_URL` / `DATA_AGENT_LLM_MODEL`). No rush — thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
