pan3793 commented on code in PR #7417:
URL: https://github.com/apache/kyuubi/pull/7417#discussion_r3153317374
##########
externals/kyuubi-data-agent-engine/src/main/java/org/apache/kyuubi/engine/dataagent/tool/AgentTool.java:
##########
@@ -50,7 +50,10 @@ default ToolRiskLevel riskLevel() {
* Execute the tool with the given deserialized arguments.
*
* @param args the deserialized arguments from the LLM's tool call
+ * @param ctx per-invocation context (session id, etc.); never null — use
{@link
+ * ToolContext#EMPTY} for calls without a session. Tools that are
session-agnostic may ignore
+ * it.
* @return the result string to feed back to the LLM
*/
- String execute(T args);
+ String execute(T args, ToolContext ctx);
Review Comment:
can we put ctx at first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
