pan3793 commented on code in PR #7417:
URL: https://github.com/apache/kyuubi/pull/7417#discussion_r3128053387
##########
externals/kyuubi-data-agent-engine/pom.xml:
##########
@@ -50,19 +50,48 @@
<version>${project.version}</version>
</dependency>
+ <!-- OpenAI official Java SDK -->
<dependency>
<groupId>com.openai</groupId>
<artifactId>openai-java</artifactId>
+ <version>${openai.sdk.version}</version>
</dependency>
+ <!-- JSON Schema generation from Jackson-annotated classes -->
<dependency>
<groupId>com.github.victools</groupId>
<artifactId>jsonschema-generator</artifactId>
+ <version>${victools.jsonschema.version}</version>
</dependency>
-
<dependency>
<groupId>com.github.victools</groupId>
<artifactId>jsonschema-module-jackson</artifactId>
+ <version>${victools.jsonschema.version}</version>
+ </dependency>
+
+ <!-- SQLite JDBC driver -->
+ <dependency>
+ <groupId>org.xerial</groupId>
+ <artifactId>sqlite-jdbc</artifactId>
+ <version>${sqlite.version}</version>
+ </dependency>
+
+ <!-- MySQL JDBC driver (also works for StarRocks) -->
+ <dependency>
+ <groupId>com.mysql</groupId>
+ <artifactId>mysql-connector-j</artifactId>
Review Comment:
SQLite, and PostgreSQL drivers have no license issues, and they are the most
popular RDBMS in the AI area. I'm fine to bundle them, as long as the overall
size of the final binary tgz is under control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
