oleg-zinovev commented on code in PR #12096:
URL: https://github.com/apache/ignite/pull/12096#discussion_r3357154364
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/window/BufferingWindowPartition.java:
##########
@@ -76,14 +77,15 @@ final class BufferingWindowPartition<Row> extends
WindowPartitionBase<Row> {
}
Row resultRow = createResultRow(factory, currRow, accResults);
- output.add(resultRow);
+ output.accept(resultRow);
prevRow = currRow;
}
}
/** {@inheritDoc} */
@Override public void reset() {
+ buf.forEach(this::onRowRemoved);
Review Comment:
@alex-plekhanov
I know I should finish dealing with query planning issues, but I’ve reduced
the number of row‑size calculations to 1 in the alternative implementation...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
