oleg-zinovev commented on code in PR #12096:
URL: https://github.com/apache/ignite/pull/12096#discussion_r3348725986
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/window/BufferingWindowPartition.java:
##########
@@ -76,14 +77,15 @@ final class BufferingWindowPartition<Row> extends
WindowPartitionBase<Row> {
}
Row resultRow = createResultRow(factory, currRow, accResults);
- output.add(resultRow);
+ output.accept(resultRow);
prevRow = currRow;
}
}
/** {@inheritDoc} */
@Override public void reset() {
+ buf.forEach(this::onRowRemoved);
Review Comment:
@alex-plekhanov
Hi.
Unfortunately, we cannot call `nodeMemoryTracker::reset` here, since
`outBuf` may contain rows that have not yet been passed to the downstream.
In the alternative implementation, the number of row size calculations has
been reduced to 2. Perhaps this will be a sufficient solution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
