alex-plekhanov commented on PR #12096: URL: https://github.com/apache/ignite/pull/12096#issuecomment-4554481064
> 2. Refactor WindowNode to: > * avoid long locks during aggregate calculations; Let's keep it as is and fix by another ticket. In scope of the current ticket just fix WindowNode memory tracker issues. > I’ve freed up time to work on this and expect to finish within a week. Could you please identify any remaining issues in the query planning process, or is this part of the functionality considered sufficiently complete? Only issue related to planning is https://github.com/apache/ignite/pull/12096#discussion_r2227589427 It looks suspicious, usually we return null when node traits are not satisfy proposed traits There are also one optimization proposal (https://github.com/apache/ignite/pull/12096#discussion_r3029833735) and couple of unresolved code style issues left in production code. Other issues related to tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
