adityamukho commented on code in PR #7488:
URL: https://github.com/apache/ignite-3/pull/7488#discussion_r2757785492
##########
modules/network/src/main/java/org/apache/ignite/internal/network/CriticalStripedThreadPoolExecutorFactory.java:
##########
@@ -64,6 +93,12 @@ CriticalStripedThreadPoolExecutor create(ChannelType
channelType) {
var threadFactory = IgniteMessageServiceThreadFactory.create(nodeName,
poolName, log, NOTHING_ALLOWED);
var executor = new
CriticalStripedThreadPoolExecutor(stripeCountForIndex(channelTypeId),
threadFactory, false, 0);
+ if (metricManager != null && metricNamePrefix != null) {
+ String metricName = String.format("%s.%s", metricNamePrefix,
channelType.name());
+
+ executor.initMetricSource(metricManager, metricName,
metricDescription);
Review Comment:
However, if we stick with the nullable metric-related parameters, I think it
is better to use the current approach of null-checks followed by init.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
