adityamukho commented on code in PR #7488:
URL: https://github.com/apache/ignite-3/pull/7488#discussion_r2753187077
##########
modules/network/src/main/java/org/apache/ignite/internal/network/CriticalStripedThreadPoolExecutorFactory.java:
##########
@@ -64,6 +93,12 @@ CriticalStripedThreadPoolExecutor create(ChannelType
channelType) {
var threadFactory = IgniteMessageServiceThreadFactory.create(nodeName,
poolName, log, NOTHING_ALLOWED);
var executor = new
CriticalStripedThreadPoolExecutor(stripeCountForIndex(channelTypeId),
threadFactory, false, 0);
+ if (metricManager != null && metricNamePrefix != null) {
+ String metricName = String.format("%s.%s", metricNamePrefix,
channelType.name());
+
+ executor.initMetricSource(metricManager, metricName,
metricDescription);
Review Comment:
We can, but that would require either passing nullable metrics params to the
constructor or have two different constructors. I can make the change using the
former approach, since it is already used above in
`CriticalStripedThreadPoolExecutorFactory`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
