adityamukho commented on code in PR #7488:
URL: https://github.com/apache/ignite-3/pull/7488#discussion_r2753172212
##########
modules/network/src/main/java/org/apache/ignite/internal/network/CriticalStripedThreadPoolExecutorFactory.java:
##########
@@ -43,18 +45,45 @@ class CriticalStripedThreadPoolExecutorFactory {
private final List<CriticalWorker> registeredWorkers;
+ @Nullable
+ private final MetricManager metricManager;
+
+ @Nullable
+ private final String metricNamePrefix;
+
+ @Nullable
+ private final String metricDescription;
+
+ @SuppressWarnings("unused")
Review Comment:
I added a new constructor to pass metrics-related params, but wanted to
preserve the old constructor for potential use in places where metrics are
deemed unnecessary. Since the old constructor is not used anywhere after the
changes in this PR (but I still considered it worthwhile to preserve it), I
added the suppression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
