tkalkirill commented on code in PR #6442:
URL: https://github.com/apache/ignite-3/pull/6442#discussion_r2282534543
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PageHeader.java:
##########
@@ -96,13 +104,13 @@ public static boolean dirty(long absPtr, boolean dirty) {
* @param absPtr Absolute pointer.
* @param flag Flag mask.
*/
- private static boolean flag(long absPtr, long flag) {
- assert (flag & 0xFFFFFFFFFFFFFFL) == 0;
+ private static boolean flag(long absPtr, int flag) {
+ assert (flag & 0xFFFFFF) == 0;
Review Comment:
I don't understand, it used to be limited to one byte, nothing is changing
and more than one byte is not needed yet. This header is stored only in memory,
if someone needs to change it, they can do it by studying the code. If I change
something else, it will require changes in the code that will not affect
anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
