ibessonov commented on code in PR #6442:
URL: https://github.com/apache/ignite-3/pull/6442#discussion_r2282487508
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PageHeader.java:
##########
@@ -96,13 +104,13 @@ public static boolean dirty(long absPtr, boolean dirty) {
* @param absPtr Absolute pointer.
* @param flag Flag mask.
*/
- private static boolean flag(long absPtr, long flag) {
- assert (flag & 0xFFFFFFFFFFFFFFL) == 0;
+ private static boolean flag(long absPtr, int flag) {
+ assert (flag & 0xFFFFFF) == 0;
Review Comment:
Does it need to work like before? Previously we checked that only the
highest byte is used because of "relative pointer". You moved flags from offset
8 to offset 12, and relative pointer is not used anymore. So, the existence of
this check requires an explanation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
