ibessonov commented on code in PR #6442:
URL: https://github.com/apache/ignite-3/pull/6442#discussion_r2282525125
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PageHeader.java:
##########
@@ -96,13 +104,13 @@ public static boolean dirty(long absPtr, boolean dirty) {
* @param absPtr Absolute pointer.
* @param flag Flag mask.
*/
- private static boolean flag(long absPtr, long flag) {
- assert (flag & 0xFFFFFFFFFFFFFFL) == 0;
+ private static boolean flag(long absPtr, int flag) {
+ assert (flag & 0xFFFFFF) == 0;
Review Comment:
But does it make sense to limit flags to a single byte only? If that's a
conscious decision from your side then that's fine. I don't think that it is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
