tkalkirill commented on code in PR #6357:
URL: https://github.com/apache/ignite-3/pull/6357#discussion_r2269784902
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/exp/ExpressionFactoryImplTest.java:
##########
@@ -305,7 +306,7 @@ void multiBoundConditionsAreMergedCorrectly() {
.add("C1", SqlTypeName.INTEGER)
.build();
- RexNode intValue1 = rexBuilder.makeExactLiteral(new BigDecimal("1"));
+ RexNode intValue1 = rexBuilder.makeExactLiteral(BigDecimal.ONE);
Review Comment:
This is a test, not hot production code.
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/exp/ExpressionFactoryImplTest.java:
##########
@@ -122,7 +122,7 @@ void multiBoundConditionAreOrderedCorrectly() {
.add("C1", SqlTypeName.INTEGER)
.build();
- RexNode intValue1 = rexBuilder.makeExactLiteral(new BigDecimal("1"));
+ RexNode intValue1 = rexBuilder.makeExactLiteral(BigDecimal.ONE);
Review Comment:
This is a test, not hot production code.
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/exp/IgniteSqlFunctionsTest.java:
##########
@@ -89,17 +89,17 @@ public void testBooleanObjectToBigDecimal() {
@Test
public void testPrimitiveToDecimal() {
assertEquals(
- new BigDecimal(10),
+ BigDecimal.TEN,
Review Comment:
This is a test, not hot production code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
