ivanzlenko commented on code in PR #6357:
URL: https://github.com/apache/ignite-3/pull/6357#discussion_r2269780584


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/PartitionSet.java:
##########
@@ -188,7 +188,7 @@ public int size() {
 
             @Override
             public PartitionSet copy() {
-                return PartitionSet.of(partId);
+                return of(partId);

Review Comment:
   In this particular instance usage of of() method is in fact a bug. Why on 
Earth we need to re-create another instance of completely immutable object? 
This whole interface unfortunately plagued with anonymous classes and should be 
refactored.   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to