ivanzlenko commented on code in PR #6357:
URL: https://github.com/apache/ignite-3/pull/6357#discussion_r2269774783


##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/DataSourceScanNodeExecutionTest.java:
##########
@@ -300,37 +299,34 @@ static class IterableDataSource implements 
ScannableDataSource {
         public Publisher<InternalTuple> scan() {
             Iterator<InternalTuple> it = iterable.iterator();
 
-            return new Publisher<InternalTuple>() {
-                @Override
-                public void subscribe(Subscriber<? super InternalTuple> 
subscriber) {
-                    Subscription subscription = new Subscription() {
-                        @Override
-                        public void request(long n) {
-                            if (n <= 0) {
-                                subscriber.onError(new 
IllegalArgumentException());
+            return subscriber -> {

Review Comment:
   I'm not sure whether we need to care about this in the test class. In this 
particular instance this change improves readability and eliminates yet another 
warning from IDE.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to