zstan commented on code in PR #6213:
URL: https://github.com/apache/ignite-3/pull/6213#discussion_r2197247975
##########
modules/runner/src/test/java/org/apache/ignite/internal/configuration/compatibility/framework/ConfigurationTreeComparator.java:
##########
@@ -105,6 +116,22 @@ private ConfigNode find(ConfigNode node,
Collection<ConfigNode> candidates) {
}
}
+ if (deletedItems == null) {
+ deletedItems = new
ArrayList<>(compContext.configurationModules().size());
+
+ for (ConfigurationModule module :
compContext.configurationModules()) {
+ KeyIgnorer keyIgnorer =
KeyIgnorer.fromDeletedPrefixes(module.deletedPrefixes());
+
+ deletedItems.add(keyIgnorer);
+ }
+ }
Review Comment:
i think we agreed that we don`t know how to correct here, but i move it, ok
##########
modules/runner/src/test/java/org/apache/ignite/internal/configuration/compatibility/framework/ConfigurationTreeScanner.java:
##########
@@ -145,12 +144,40 @@ private static ConfigNode createNodeForField(ConfigNode
parent, Field field) {
List<ConfigAnnotation> annotations =
collectAdditionalAnnotations(field);
EnumSet<ConfigNode.Flags> flags = extractFlags(field);
+ Set<String> legacyNames = extractLegacy(field);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
