AMashenkov commented on code in PR #6213:
URL: https://github.com/apache/ignite-3/pull/6213#discussion_r2195427109
##########
modules/runner/src/test/java/org/apache/ignite/internal/configuration/compatibility/framework/ConfigurationTreeComparator.java:
##########
@@ -105,6 +116,22 @@ private ConfigNode find(ConfigNode node,
Collection<ConfigNode> candidates) {
}
}
+ if (deletedItems == null) {
+ deletedItems = new
ArrayList<>(compContext.configurationModules().size());
+
+ for (ConfigurationModule module :
compContext.configurationModules()) {
+ KeyIgnorer keyIgnorer =
KeyIgnorer.fromDeletedPrefixes(module.deletedPrefixes());
+
+ deletedItems.add(keyIgnorer);
+ }
+ }
Review Comment:
From one side, `deletedPrefixes` in a root node are just values that should
be compared for compatibility.
This is what the next line do:
`candidate.deletedPrefixes().containsAll(node.deletedPrefixes())`
From another side, we use them to exclude old configs' nodes from check.
Actually, we may have another logic based not only on `deletedPrefixes`.
So, I'd hide this logic in the context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
