AMashenkov commented on code in PR #6213:
URL: https://github.com/apache/ignite-3/pull/6213#discussion_r2195443476
##########
modules/runner/src/test/java/org/apache/ignite/internal/configuration/compatibility/framework/ConfigurationTreeComparator.java:
##########
@@ -105,6 +116,22 @@ private ConfigNode find(ConfigNode node,
Collection<ConfigNode> candidates) {
}
}
+ if (deletedItems == null) {
+ deletedItems = new
ArrayList<>(compContext.configurationModules().size());
+
+ for (ConfigurationModule module :
compContext.configurationModules()) {
+ KeyIgnorer keyIgnorer =
KeyIgnorer.fromDeletedPrefixes(module.deletedPrefixes());
+
+ deletedItems.add(keyIgnorer);
+ }
+ }
Review Comment:
Does it make sense to move checking for deleted node from the Validator to
the Visitor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
