ibessonov commented on code in PR #5816:
URL: https://github.com/apache/ignite-3/pull/5816#discussion_r2100288807
##########
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/ConfigurationChanger.java:
##########
@@ -694,16 +698,18 @@ private ConfigurationStorageListener
configurationStorageListener() {
return changedEntries -> {
Map<String, ? extends Serializable> changedValues =
changedEntries.values();
- // We need to ignore deletion of deprecated values.
- ignoreDeleted(changedValues, keyIgnorer);
-
StorageRoots oldStorageRoots = storageRoots;
SuperRoot oldSuperRoot = oldStorageRoots.roots;
SuperRoot oldSuperRootNoDefaults =
oldStorageRoots.rootsWithoutDefaults;
SuperRoot newSuperRoot = oldSuperRoot.copy();
SuperRoot newSuperNoDefaults = oldSuperRootNoDefaults.copy();
+ // We need to ignore deletion of deprecated values.
+ ignoreDeleted(changedValues, keyIgnorer);
+ // We need to ignore deletion of legacy values.
+ deleteLegacyKeys(oldStorageRoots, changedValues);
Review Comment:
We need to check that deprecated configuration values keep working. Maybe we
broke them. If we did - I apologize, I didn't think about these consequences in
advance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
