Copilot commented on code in PR #5816:
URL: https://github.com/apache/ignite-3/pull/5816#discussion_r2097242440
##########
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/validation/ConfigurationValidatorImpl.java:
##########
@@ -251,6 +252,14 @@ private void validate(InnerNode lastInnerNode, String
fieldName, Object val) {
}
}
+ for (Field field : schemaType.getDeclaredFields()) {
+ for (String legacyName : legacyNames(field)) {
+ if (legacyName.equals(publicName)) {
Review Comment:
The comparison 'legacyName.equals(publicName)' appears incorrect since
'publicName' is a method reference. Consider invoking 'publicName(field)' to
compare the legacy name with the actual public name defined for the field.
```suggestion
if (legacyName.equals(publicName(field))) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
