Phillippko commented on code in PR #5816:
URL: https://github.com/apache/ignite-3/pull/5816#discussion_r2099925426
##########
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/asm/InnerNodeAsmGenerator.java:
##########
@@ -1188,19 +1189,25 @@ private void addNodeConstructMethod(
);
// this.changePolymorphicTypeId(src == null ? null :
src.unwrap(FieldType.class));
- switchBuilder.addCase(
- publicName,
- new BytecodeBlock()
- .append(constructMtd.getThis())
- .append(getTypeIdFromSrcVar)
- .invokeVirtual(changePolymorphicTypeIdMtd)
- .ret()
- );
+ BytecodeBlock ret = new BytecodeBlock()
+ .append(constructMtd.getThis())
+ .append(getTypeIdFromSrcVar)
+ .invokeVirtual(changePolymorphicTypeIdMtd)
+ .ret();
+
+ addCaseForAllPublicNames(switchBuilder, schemaField, ret);
} else {
switchBuilder.addCase(
publicName,
treatSourceForConstruct(constructMtd, schemaField,
fieldDef).ret()
);
+
Review Comment:
Removed addCaseForAllPublicNames, use new bytecode for each name, just in
case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
