Phillippko commented on code in PR #5728:
URL: https://github.com/apache/ignite-3/pull/5728#discussion_r2071652034
##########
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/ConfigurationChanger.java:
##########
@@ -118,6 +124,9 @@ public abstract class ConfigurationChanger implements
DynamicConfigurationChange
/** Flag indicating whether the component is started. */
private final AtomicBoolean started = new AtomicBoolean(false);
+ /** Keys that were deleted, but still present in configuration. */
+ private Collection<String> ignoredKeys;
Review Comment:
Expanded javadoc - we use this key to delete keys in changeInternally()
method. We could add it as a parameter instead, but imho it's not much better
than current approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
