ibessonov commented on code in PR #5728:
URL: https://github.com/apache/ignite-3/pull/5728#discussion_r2068594877
##########
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/ConfigurationChanger.java:
##########
@@ -670,14 +688,21 @@ private void validateConfiguration(SuperRoot curRoots,
SuperRoot changes) {
private ConfigurationStorageListener configurationStorageListener() {
return changedEntries -> {
+ Map<String, ? extends Serializable> changedValues =
changedEntries.values();
+
+ // We need to ignore deletion of deprecated values.
+ for (String ignoredValue : ignoredKeys) {
+ changedValues.remove(ignoredValue);
+ }
Review Comment:
Could you please explain what's going on here? I don't think that it is
possible to receive deleted values from a storage notification, they were
filtered-out before that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
