Phillippko commented on code in PR #5728:
URL: https://github.com/apache/ignite-3/pull/5728#discussion_r2068600988
##########
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/ConfigurationChanger.java:
##########
@@ -670,14 +688,21 @@ private void validateConfiguration(SuperRoot curRoots,
SuperRoot changes) {
private ConfigurationStorageListener configurationStorageListener() {
return changedEntries -> {
+ Map<String, ? extends Serializable> changedValues =
changedEntries.values();
+
+ // We need to ignore deletion of deprecated values.
+ for (String ignoredValue : ignoredKeys) {
+ changedValues.remove(ignoredValue);
+ }
Review Comment:
On startup we delete deleted keys from storage, so they are passed to
storage.write() with "null" values. In the end of write() listener is called,
with all changed values (including nulls)
##########
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/ConfigurationChanger.java:
##########
@@ -670,14 +688,21 @@ private void validateConfiguration(SuperRoot curRoots,
SuperRoot changes) {
private ConfigurationStorageListener configurationStorageListener() {
return changedEntries -> {
+ Map<String, ? extends Serializable> changedValues =
changedEntries.values();
+
+ // We need to ignore deletion of deprecated values.
+ for (String ignoredValue : ignoredKeys) {
+ changedValues.remove(ignoredValue);
+ }
Review Comment:
On startup we delete deleted keys from storage, so they are passed to
storage.write() with "null" values. In the end of write() listener is called,
with all changed values (including this nulls)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
