zstan commented on code in PR #5515:
URL: https://github.com/apache/ignite-3/pull/5515#discussion_r2034459329


##########
modules/api/src/testFixtures/java/org/apache/ignite/table/AbstractImmutableTupleTest.java:
##########
@@ -440,4 +436,13 @@ private static int tailFactor(int precision) {
                 throw new IllegalArgumentException("Unsupported type: " + 
type);
         }
     }
+
+    private static Instant generateInstant(Random rnd) {

Review Comment:
   i can`t see any validation, check with 
   ```
       private static Instant generateInstant(Random rnd) {
           long res = LocalDateTime.of(LocalDate.of(11000, 12, 31), 
LocalTime.MAX).toInstant(ZoneOffset.UTC).toEpochMilli();
   
           return Instant.ofEpochMilli(res);
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to