xtern commented on code in PR #5515:
URL: https://github.com/apache/ignite-3/pull/5515#discussion_r2026741608
##########
modules/platforms/dotnet/Apache.Ignite.Tests/Proto/ColocationHashTests.cs:
##########
@@ -96,10 +96,11 @@ public class ColocationHashTests : IgniteTestsBase
LocalTime.Noon,
LocalDateTime.FromDateTime(DateTime.UtcNow).TimeOfDay,
default(LocalTime),
- new LocalDateTime(year: 1, month: 1, day: 1, hour: 1, minute: 1,
second: 1, millisecond: 1),
+
+ // Minimum allowed DATETIME value.
+ new LocalDateTime(year: 1, month: 1, day: 1, hour: 18, minute: 0,
second: 0, millisecond: 0),
new LocalDateTime(year: 2022, month: 10, day: 22, hour: 10, minute:
30, second: 55, millisecond: 123),
LocalDateTime.FromDateTime(DateTime.UtcNow),
- default(LocalDateTime),
Review Comment:
default(LocalDateTime) = '0001-01-01 00:00:00' (less then current min for
DATETIME) :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
