xtern commented on code in PR #5515:
URL: https://github.com/apache/ignite-3/pull/5515#discussion_r2033194379
##########
modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItKeyValueViewSimpleSchemaApiTest.java:
##########
@@ -537,6 +540,167 @@ public void putGetAllTypes(AllTypesTestCase testCase) {
}
}
+ @ParameterizedTest
+ @MethodSource("dateBoundaryTestCases")
+ @SuppressWarnings("ThrowableNotThrown")
+ public void putDateBoundaryValues(AllTypesTestCase testCase) {
+ try {
+ KeyValueView<Long, Object> view = testCase.view();
+
+ // Put min and max allowed values.
+ view.put(null, 1L, SchemaUtils.DATE_MIN);
+ view.put(null, 2L, SchemaUtils.DATE_MAX);
+
+ // Verify them using KV API.
+ {
+ assertEquals(SchemaUtils.DATE_MIN, view.get(null, 1L));
+ assertEquals(SchemaUtils.DATE_MAX, view.get(null, 2L));
+ }
+
+ // Verify them using SQL API.
+ {
+ String query = "SELECT VAL, VAL::VARCHAR FROM " +
testCase.tableName + " WHERE id = ?";
+ {
+ List<List<Object>> res = sql(query, 1);
+
+ assertEquals(SchemaUtils.DATE_MIN, res.get(0).get(0));
+ assertEquals("0001-01-01", res.get(0).get(1));
+ }
+ {
+ List<List<Object>> res = sql(query, 2);
+
+ assertEquals(SchemaUtils.DATE_MAX, res.get(0).get(0));
+ assertEquals("9999-12-31", res.get(0).get(1));
Review Comment:
Done, thanks
##########
modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItKeyValueViewSimpleSchemaApiTest.java:
##########
@@ -537,6 +540,167 @@ public void putGetAllTypes(AllTypesTestCase testCase) {
}
}
+ @ParameterizedTest
+ @MethodSource("dateBoundaryTestCases")
+ @SuppressWarnings("ThrowableNotThrown")
+ public void putDateBoundaryValues(AllTypesTestCase testCase) {
+ try {
+ KeyValueView<Long, Object> view = testCase.view();
+
+ // Put min and max allowed values.
+ view.put(null, 1L, SchemaUtils.DATE_MIN);
+ view.put(null, 2L, SchemaUtils.DATE_MAX);
+
+ // Verify them using KV API.
+ {
+ assertEquals(SchemaUtils.DATE_MIN, view.get(null, 1L));
+ assertEquals(SchemaUtils.DATE_MAX, view.get(null, 2L));
+ }
+
+ // Verify them using SQL API.
+ {
+ String query = "SELECT VAL, VAL::VARCHAR FROM " +
testCase.tableName + " WHERE id = ?";
+ {
+ List<List<Object>> res = sql(query, 1);
+
+ assertEquals(SchemaUtils.DATE_MIN, res.get(0).get(0));
+ assertEquals("0001-01-01", res.get(0).get(1));
Review Comment:
Done, thanks
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/IgniteMethod.java:
##########
@@ -59,6 +59,15 @@ public enum IgniteMethod {
/** See {@link IgniteSqlFunctions#subtractTimeZoneOffset(long, TimeZone)}.
**/
SUBTRACT_TIMEZONE_OFFSET(IgniteSqlFunctions.class,
"subtractTimeZoneOffset", long.class, TimeZone.class),
+ /** See {@link IgniteSqlFunctions#toDateExact(int)}. **/
+ TO_DATE_EXACT(IgniteSqlFunctions.class, "toDateExact", int.class),
+
+ /** See {@link IgniteSqlFunctions#toTimestampExact(Object)}. **/
+ TO_TIMESTAMP_EXACT(IgniteSqlFunctions.class, "toTimestampExact",
long.class),
+
+ /** See {@link IgniteSqlFunctions#toTimestampLtzExact(Object)}. **/
+ TO_TIMESTAMP_WLTZ_EXACT(IgniteSqlFunctions.class, "toTimestampLtzExact",
Object.class),
Review Comment:
Done, thanks
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/IgniteSqlFunctions.java:
##########
@@ -45,6 +50,15 @@
* Ignite SQL functions.
*/
public class IgniteSqlFunctions {
+ private static final int DATE_MIN_INTERNAL = (int)
TypeUtils.toInternal(SchemaUtils.DATE_MIN, LocalDate.class);
Review Comment:
Fixed, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
