ascherbakoff commented on code in PR #5383:
URL: https://github.com/apache/ignite-3/pull/5383#discussion_r2020480177
##########
modules/client/src/main/java/org/apache/ignite/internal/client/table/ClientTable.java:
##########
@@ -321,9 +342,9 @@ public static void writeTx(@Nullable Transaction tx,
PayloadOutputChannel out) {
*/
public <T> CompletableFuture<T> doSchemaOutOpAsync(
int opCode,
- BiConsumer<ClientSchema, PayloadOutputChannel> writer,
+ IgniteTriConsumer<ClientSchema, PayloadOutputChannel,
WriteContext> writer,
Review Comment:
I would prefer to leave it as is, otherwise PayloadOutputChannel will lose
it's immutability, which is nice to have.
Alternatively, I can move PayloadOutputChannel to WriteContext, which looks
better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
