zstan commented on code in PR #5357:
URL: https://github.com/apache/ignite-3/pull/5357#discussion_r1986659598
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/datatypes/varbinary/ItVarBinaryDmlTest.java:
##########
@@ -70,4 +71,10 @@ public void testInsertHexLiteral() {
protected DataTypeTestSpec<VarBinary> getTypeSpec() {
return DataTypeTestSpecs.VARBINARY_TYPE;
}
+
+ @Override
+ public void testUpdateFromLiteral(TestTypeArguments<VarBinary> arguments) {
Review Comment:
seems you can remove this test from base class too
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/datatypes/tests/BaseJoinDataTypeTest.java:
##########
@@ -88,6 +74,7 @@ public void testNonEquijoin(String name, TestTypeArguments<T>
arguments, String
runSql(insert1);
String insert2 = format("INSERT INTO t_join_{} (id, test_key)
VALUES(2, {})", arguments.typeName(1), arguments.valueExpr(1));
+ System.out.println("!!!!3 " + insert2);
Review Comment:
debug log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
