rpuch commented on code in PR #5209:
URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1982797427
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/TxManager.java:
##########
@@ -146,8 +146,11 @@ default InternalTransaction
beginExplicitRo(HybridTimestampTracker timestampTrac
* @param txId Transaction id.
* @param ts The timestamp which is associated to txn completion.
* @param commit {@code True} if a commit requested.
+ * @param timeoutExceeded {@code True} if a timeout exceeded. 'commit' !=
'timeoutExceeded != false'.
Review Comment:
`timeoutExceeded != false` is the same as just `timeoutExceeded`, isn't it?
So the expression simplifies to `commit != timeoutExceeded`, but if they both
are false, this should be allowed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
