rpuch commented on code in PR #5209:
URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1987419799
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##########
@@ -519,6 +531,7 @@ private <T> CompletableFuture<T> enlistInTx(
}).thenCompose(identity());
}
+
Review Comment:
Was this blank line added on purpose?
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##########
@@ -1200,8 +1228,8 @@ private CompletableFuture<Void> updateAllWithRetry(
// Will be finished in one RTT.
return postEnlist(fut, false, tx, true).handle((r, e) -> {
if (e != null) {
- // TODO: IGNITE-24244
- long timeout = tx.isReadOnly() ? tx.timeout() : 3_000;
+ long timeout = tx.getTimeoutOrDefault(getDefaultTimeout(tx));
Review Comment:
The whole expression is used a few times. How about extracting it to a
method like `getTimeoutOrDefault(InternalTransaction)`? The duplication is
currently small, but it's still there.
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##########
@@ -1200,8 +1228,8 @@ private CompletableFuture<Void> updateAllWithRetry(
// Will be finished in one RTT.
return postEnlist(fut, false, tx, true).handle((r, e) -> {
if (e != null) {
- // TODO: IGNITE-24244
- long timeout = tx.isReadOnly() ? tx.timeout() : 3_000;
+ long timeout = tx.getTimeoutOrDefault(getDefaultTimeout(tx));
+
Review Comment:
Is this blank line added on purpose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
