PakhomovAlexander commented on code in PR #5209:
URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1987706753
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/TxManagerImpl.java:
##########
@@ -416,34 +416,49 @@ private InternalTransaction beginBusy(
if (readOnly) {
HybridTimestamp beginTimestamp = clockService.now();
-
- UUID txId =
transactionIdGenerator.transactionIdFor(beginTimestamp, options.priority());
-
- tx = beginReadOnlyTransaction(timestampTracker, beginTimestamp,
txId, implicit, options);
+ tx = beginReadOnlyTransaction(timestampTracker, beginTimestamp,
implicit, options);
} else {
HybridTimestamp beginTimestamp =
createBeginTimestampWithIncrementRwTxCounter();
-
- UUID txId =
transactionIdGenerator.transactionIdFor(beginTimestamp, options.priority());
-
- // TODO: RW timeouts will be supported in
https://issues.apache.org/jira/browse/IGNITE-24244
- // long timeout = options.timeoutMillis() == 0 ?
txConfig.readWriteTimeout().value() : options.timeoutMillis();
- long timeout = 3_000;
-
- tx = new ReadWriteTransactionImpl(this, timestampTracker, txId,
localNodeId, implicit, timeout);
+ tx = beginReadWriteTransaction(timestampTracker, beginTimestamp,
implicit, options);
}
txStateVolatileStorage.initialize(tx);
return tx;
}
+ private ReadWriteTransactionImpl beginReadWriteTransaction(
+ HybridTimestampTracker timestampTracker,
+ HybridTimestamp beginTimestamp,
+ boolean implicit,
+ InternalTxOptions options) {
+
+ UUID txId = transactionIdGenerator.transactionIdFor(beginTimestamp,
options.priority());
Review Comment:
I get your point and I believe it is really easy to confuse 'no timeout at
all' vs 'use server default' for 0. I've adjusted both places(`TxManagerImpl`
and `ClientTransactions`) where we use this 0 and explicitly wrote a java
comment.
But Im not ready to introduce a coupling point here. We do not have shared
'constants' place and I don't think we should.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
