sashapolo commented on code in PR #5300:
URL: https://github.com/apache/ignite-3/pull/5300#discussion_r1978866458
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -1331,34 +1337,47 @@ public CompletableFuture<Void>
stopAsync(ComponentContext componentContext) {
return Assignments.fromBytes(entry.value());
}
- private CompletableFuture<Void>
weakStopAndDestroyPartition(ZonePartitionId zonePartitionId, long revision) {
- return replicaMgr.weakStopReplica(
- zonePartitionId,
- WeakReplicaStopReason.EXCLUDED_FROM_ASSIGNMENTS,
- () -> stopAndDestroyPartition(zonePartitionId, revision)
- );
- }
-
/**
- * Stops all resources associated with a given partition, like replicas
and partition trackers.
+ * Stops zone replica, executes a given action and fires a given local
event after if are not null.
Review Comment:
```suggestion
* Stops zone replica, executes a given action and fires a given local
event after.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
