sashapolo commented on code in PR #5300:
URL: https://github.com/apache/ignite-3/pull/5300#discussion_r1976683379


##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/util/StorageUtils.java:
##########
@@ -137,6 +138,7 @@ public static void 
throwExceptionDependingOnStorageStateOnRebalance(StorageState
     public static void throwExceptionDependingOnStorageState(StorageState 
state, String storageInfo) {
         switch (state) {
             case CLOSED:
+                assert !IgniteSystemProperties.enabledColocation() : 
createStorageClosedErrorMessage(storageInfo);

Review Comment:
   Do you have a precedent for this? Because it looks very strange now. For 
example, why do you only check the CLOSED status and no other statuses? Why 
does accessing a closed storage not result in test failures?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to