JAkutenshi commented on code in PR #5300:
URL: https://github.com/apache/ignite-3/pull/5300#discussion_r1978853188
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -1432,6 +1455,25 @@ public void loadTableListenerToZoneReplica(
resources.snapshotStorageFactory().addMvPartition(tablePartitionId.tableId(),
partitionMvStorageAccess);
}
+ /**
+ * Load a new table partition listener to the zone replica.
+ *
+ * @param zonePartitionId Zone partition id.
+ * @param tableId Table's identifier.
+ */
+ public void unloadTableResourcesFromZoneReplica(
+ ZonePartitionId zonePartitionId,
+ int tableId
+ ) {
+ ZonePartitionResources resources =
zoneResourcesManager.getZonePartitionResources(zonePartitionId);
+
+ resources.replicaListenerFuture().thenAccept(zoneReplicaListener ->
zoneReplicaListener.removeTableReplicaListener(tableId));
Review Comment:
Done
##########
modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItReplicaLifecycleTest.java:
##########
@@ -636,6 +637,32 @@ public void testScanCloseReplicaRequest() throws Exception
{
assertDoesNotThrow(tx::commit);
}
+ @Test
+ public void testNodeStop() throws Exception {
+ // Prepare a single node cluster.
+ startCluster(1);
+ Node node = getNode(0);
+
+ // Prepare a zone.
+ String zoneName = "test_zone";
+ createZone(node, zoneName, 1, 1);
+
+ // Create a table to work with.
+ String tableName = "test_table";
+ createTable(node, zoneName, tableName);
+ int tableId = TableTestUtils.getTableId(node.catalogManager,
tableName, node.hybridClock.nowLong());
+ InternalTable internalTable =
node.tableManager.table(tableId).internalTable();
+
+ // Stop the node
+ stopNode(0);
+
+ // Check that the storages close method was triggered
+ verify(internalTable.storage(), times(1))
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
