zstan commented on code in PR #4927:
URL: https://github.com/apache/ignite-3/pull/4927#discussion_r1896460421
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/KeyValueModifyPlan.java:
##########
@@ -115,7 +115,7 @@ public IgniteKeyValueModify modifyNode() {
@Override
public <RowT> AsyncCursor<InternalSqlRow> execute(
ExecutionContext<RowT> ctx,
- @Nullable InternalTransaction tx,
+ InternalTransaction tx,
Review Comment:
seems additional assert will be useful ?
assert tx.implicit();
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/KeyValueGetPlan.java:
##########
@@ -130,7 +130,7 @@ public IgniteKeyValueGet lookupNode() {
@Override
public <RowT> AsyncCursor<InternalSqlRow> execute(
ExecutionContext<RowT> ctx,
- @Nullable InternalTransaction tx,
+ InternalTransaction tx,
Review Comment:
seems additional assert will be useful ?
assert tx.implicit();
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
